Report completion accurately. #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ``TriggeredCamExposure`` device returns a ``NullStatus``, which communicates back to the RunEngine that the set operation finished immediately. This is not accurate: setting the exposure takes a small but sometimes significant amount of time. In this PR, we use the fact that Status object can be logically "AND-ed" to report when *all* status objects in a set are complete. Example: ```python In [23]: st = NullStatus() In [24]: st2 = StatusBase() In [25]: st3 = StatusBase() In [26]: st &= st2 In [27]: st &= st3 In [28]: st.done Out[28]: False In [29]: st2._finished() In [30]: st.done Out[30]: False In [31]: st3._finished() In [32]: st.done Out[32]: True ```
danielballan
force-pushed
the
report-completion-accurately
branch
from
eecffab
to
d9b0654
Compare
tacaswell
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
The
TriggeredCamExposuredevice returns aNullStatus, whichcommunicates back to the RunEngine that the set operation finished
immediately. This is not accurate: setting the exposure takes a small
but sometimes significant amount of time.
In this PR, we use the fact that Status object can be logically "AND-ed"
to report when all status objects in a set are complete. Example: