remove codecov #180
Merged
remove codecov #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We use |
|
How does this look @mrakitin ? |
mrakitin
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
Looks good to me, however, I am not 100% sure it's even used in the tests, at least https://github.com/NSLS-II/edrixs/blob/master/.github/workflows/ci-test.yml does not have anything coverage-related. It's probably OK to keep it as it's the dev dependency.
|
Yes, it crossed by mind that this is unused, but I figured this is maybe more because the repo testing is a big meagre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our build seems to throw errors
ERROR: No matching distribution found for codecov@mrakitin could you confirm that this should be removed?