Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logger action #42

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Update logger action #42

merged 1 commit into from
Sep 8, 2022

Conversation

dboulware
Copy link
Contributor

This updates the logger action to set required name parameter.

aromanielloNTIA
aromanielloNTIA approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@aromanielloNTIA aromanielloNTIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a note that this fix is only required when using a mock sensor.

@aromanielloNTIA aromanielloNTIA merged commit bca944d into master Sep 8, 2022
@aromanielloNTIA aromanielloNTIA deleted the logger_fix branch September 8, 2022 20:38
@aromanielloNTIA aromanielloNTIA added the bug Something isn't working label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aromanielloNTIA aromanielloNTIA aromanielloNTIA approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dboulware @aromanielloNTIA