Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use thread lock for entire IQ capture method #48

Merged
merged 13 commits into from Oct 23, 2023
Merged

Use thread lock for entire IQ capture method #48

merged 13 commits into from Oct 23, 2023

Conversation

aromanielloNTIA
Copy link
Member

@aromanielloNTIA aromanielloNTIA commented Oct 5, 2023 •
edited

  • Adjust the implementation of the sigan thread lock to apply to the entire IQ capture method
  • Add a plugin_version instance variable to the SignalAnalyzerInterface
  • Update pre-commit hooks and run on all files
  • Bump package version to 3.1.4

Tested and working on seadog01

@aromanielloNTIA aromanielloNTIA self-assigned this Oct 5, 2023
@aromanielloNTIA aromanielloNTIA marked this pull request as ready for review October 5, 2023 17:13
dboulware
dboulware requested changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@dboulware dboulware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See in-line comments.

src/scos_tekrsa/hardware/tekrsa_sigan.py Outdated Show resolved Hide resolved
@aromanielloNTIA aromanielloNTIA mentioned this pull request Oct 18, 2023
Merged
@aromanielloNTIA aromanielloNTIA merged commit 6fdcdcb into main Oct 23, 2023
4 checks passed
@aromanielloNTIA aromanielloNTIA deleted the adjust-iq-capture-threading-lock branch October 23, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dboulware dboulware dboulware approved these changes

Assignees

@aromanielloNTIA aromanielloNTIA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aromanielloNTIA @dboulware