Metadata contents for SEA action: add CUI marking and minor updates #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aromanielloNTIA
changed the title
dboulware
reviewed
Oct 19, 2023
| @@ -796,6 +796,7 @@ def capture_diagnostics(self, action_start_tic: float, cpu_speeds: list) -> None | |||
| "python_version": sys.version.split()[0], | |||
| "scos_sensor_version": SCOS_SENSOR_GIT_TAG, | |||
| "scos_actions_version": SCOS_ACTIONS_VERSION, | |||
| "scos_tekrsa_version": self.sigan.plugin_version, | |||
There was a problem hiding this comment.
SHouldn't this be added to SignalAnalyzerInterface?
There was a problem hiding this comment.
Yes- good point. I added it as a property and abstract method, and updated the mock sigan interface, in f5b1609.
I will make a corresponding update to scos-tekrsa momentarily.
dboulware
requested changes
Oct 19, 2023
…/scos-actions into add-sea-action-cui-markings
dboulware
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"CUI"ntia-diagnosticsv1.1.1 (ntia-diagnosticsv1.1.1 sigmf-ns-ntia#46), which adds the version ofscos_tekrsato the software diagnosticsSignalAnalyzerntia_sensormetadata struct by removing outdated code. This fixes a bug which made it impossible to use theSignalAnalyzerstruct.SignalAnalyzerInterface, adding aplugin_versionabstract method / property. Also update the mock signal analyzer interface to support this propertyNote that the inclusion of the
plugin_versionin theSignalAnalyzerInterfaceis a breaking change for sigan plugins. This is accounted for inscos_tekrsaby NTIA/scos-tekrsa#48Bumps package version to 6.4.0