Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing specs on develop #947

Closed
mattbaumann1 opened this issue Jul 1, 2022 · 1 comment · Fixed by #953
Closed

Failing specs on develop #947

mattbaumann1 opened this issue Jul 1, 2022 · 1 comment · Fixed by #953
Assignees
@mattbaumann1 @jseraf
Labels
specs

Comments

@mattbaumann1
Copy link
Collaborator

When running specs on develop while working on #946, there are a lot of failing specs. It seems like these pre-date the changes implemented for that ticket. These specs will be addressed in this ticket.
@mattbaumann1 mattbaumann1 self-assigned this Jul 1, 2022
mattbaumann1 added a commit that referenced this issue Jul 7, 2022
@mattbaumann1
changes to fix failing specs. #947
7cbe0f4 
there was a combination of 3 things going on with the specs here. Turbo required new form_for arguments. Turbo runs slightly slower requiring sleeping after a save on forms. Finally, we needed to add cocoon to the package manager.
@mattbaumann1 mattbaumann1 mentioned this issue Jul 7, 2022
Merged
@mattbaumann1
Copy link
Collaborator Author

There are still failing banners specs, but these will be dealt with after merged to develop with ticket #950

mattbaumann1 added a commit that referenced this issue Jul 7, 2022
@mattbaumann1
change sleeps to pause. #947
08908c3
@jseraf jseraf mentioned this issue Aug 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattbaumann1 mattbaumann1

@jseraf jseraf

Labels
specs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Task/fix failing specs 947 NUARIG/competitions
2 participants
@mattbaumann1 @jseraf