-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple CAS process management from integration tests #31
Conversation
Credentials are pairs (username, password). Valid credentials are those in which username == password. This intentionally coincides with Jasig CAS Server's test mode.
I have run this new configuration using
Both test suite runs passed.
I don't know if this is related to the changes in this PR. |
Strike that. Looks like I wasn't using JRuby after all for that test run. Actually using JRuby results in this:
I keep forgetting that mucking about in |
OK, now things seem to be happy (ish) on JRuby. The spawned CAS processes still don't die when they're told to die; it looks like there's something funny with @rsutphin: any comments? |
I have not tried running it myself, but the code looks reasonable to me. |
Also add URL generation tasks for CAS and ladle-controlled LDAP.
This doesn't really do the same thing as the previous form, and it doesn't actually do anything in JRuby 1.7.x. However, the [:out, :err] => "/dev/null" form causes a program abort in JRuby 1.7.x. This form doesn't.
Alright, I'll merge this. |
Decouple CAS process management from integration tests
Nice work. |
This PR contains an another approach to getting Aker's test suite running in ActiveSupport 4.0 (and better future-proofing it). My previous approach was #30; it should be ignored.
This approach uses a pair of URL generation programs to set ports for all test-related services. These generated URLs are paired with tasks to start a CAS callback and server manager. Finally, the CI script has been changed to download, start, and stop CAS servers.