survey update bug

[ignu]

stop survey titles from appending '1' to itself when calling update attributes

(also removed extra whitespace... i tend to do that when i open files)

[yoon]

The test passes with the existing code when I write it this way:

it "should not adjust the title when updating itself" do
original = Survey.new(:title => "Foo")
original.save.should be_true
original.update_attributes(:updated_at => Time.now)
original.title.should == "Foo"
end

My question is - what is the use case for re-assigning the title attribute?

[ignu]

What is the use case for appending "1" to the value of a string if it hasn't changed?

My question is - what is the use case for re-assigning the title attribute?

To let rails controllers do what they do. I'm working an admin controller for surveys for a project.

[yoon]

That isn't our use case... the use case is if someone re-imports a survey (it happens a lot) or imports a survey of the same name. How do you know which survey is which? We automatically append an increasing integer in order to differentiate surveys.

I agree that this is a bug, but the test is testing something that I'm curious about. I rewrite the test, updating some other attribute of the survey, and the bug did not appear. The bug only appears when you specifically re-assign the title attribute. I wanted to write the test in such a way that it demonstrates the motivation, not only the bug.