Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordpress plugin #31

Closed
wfsmith opened this issue Dec 11, 2013 · 2 comments
Closed

Wordpress plugin #31

wfsmith opened this issue Dec 11, 2013 · 2 comments

Comments

@wfsmith
Copy link

wfsmith commented Dec 11, 2013

Hi guys. I have written a basic Wordpress plugin for SoundCite.

You can find it here: https://github.com/wfsmith/soundcite-wordpress

It uses a TinyMCE dialog to first resolve the public soundcloud url to a track id, and then embeds it as a shortcode. The shortcode is then converted back to the necessary markup to make soundcite work.

This is my first public git repo, and my first public wordpress plugin (I've written many that we use internally), so please let me know if any issues/bugs or anything I can do to improve it.

@aendra-rininsland
Copy link

@wfsmith This looks good! Could use a config panel for setting the API key, and probably worth hooking into the wp_kses_allowed_html filter to prevent #28 from being an issue with lesser-privileged users. I haven't tested it yet, but might do so in a bit.

@scott2b
Copy link
Member

scott2b commented Sep 8, 2016

I appreciate efforts here from @wfsmith. Would like, however, to get this out of our issues list. @JoeGermuska can you clarify why this is marked as enhancement? What is the task here?

@wfsmith wfsmith closed this as completed Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants