Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docstrings to merlin.schema #35

Merged
merged 10 commits into from
Mar 9, 2022
Merged

Add docstrings to merlin.schema #35

merged 10 commits into from
Mar 9, 2022

Conversation

karlhigley
Copy link
Contributor

Bumps docstring coverage requirement to 50%

@karlhigley
Add docstrings to merlin.schema
a003abc 
Bumps docstring coverage requirement to 50%
@karlhigley karlhigley self-assigned this Mar 7, 2022
@karlhigley karlhigley added this to the 22.04 milestone Mar 7, 2022
@karlhigley karlhigley added the documentation Improvements or additions to documentation label Mar 7, 2022
@karlhigley karlhigley mentioned this pull request Mar 7, 2022
Closed
25 tasks
mikemckiernan
mikemckiernan reviewed Mar 8, 2022
View reviewed changes
Copy link
Member

@mikemckiernan mikemckiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to hold you up, so I identified the few items that I felt like I had some footing to defend.

merlin/schema/io/proto_utils.py Outdated Show resolved Hide resolved
merlin/schema/io/tensorflow_metadata.py Outdated Show resolved Hide resolved
merlin/schema/schema.py Outdated Show resolved Hide resolved
benfred
benfred reviewed Mar 8, 2022
View reviewed changes
merlin/schema/schema.py Outdated Show resolved Hide resolved
benfred
benfred reviewed Mar 8, 2022
View reviewed changes
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor things - but looks good! Thanks for adding the extra doc strings

benfred
benfred approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@karlhigley karlhigley merged commit 714d4af into NVIDIA-Merlin:main Mar 9, 2022
@viswa-nvidia viswa-nvidia mentioned this pull request Mar 31, 2022
Closed
29 tasks
@karlhigley karlhigley mentioned this pull request May 3, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemckiernan mikemckiernan mikemckiernan left review comments

@benfred benfred benfred approved these changes

@jperez999 jperez999 Awaiting requested review from jperez999

Assignees

@karlhigley karlhigley

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Merlin 22.04
Development

Successfully merging this pull request may close these issues.
3 participants
@karlhigley @benfred @mikemckiernan