Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here:
https://github.com/parallel-forall/code-samples/blob/master/series/cuda-cpp/coalescing-global/coalescing.cu
lines 54 and 70 are passing a double for the second argument:
This is not really sensible and may trigger compiler warnings like this:
coalescing.cu:70: warning: passing âdoubleâ for argument 2 to âcudaError_t cudaMemset(void*, int, size_t)â
I would recommend changing those 2 instances of 0.0 to just 0
I guess there is also a fix for "no newline at end of file" which may have been inserted by my editor