Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test_operator_water.py #1075

Merged
merged 5 commits into from
Aug 2, 2019
Merged

add test_operator_water.py #1075

merged 5 commits into from
Aug 2, 2019

Conversation

kychennv
Copy link
Contributor

Signed-off-by: kychennv kychen@nvidia.com

Why we need this PR?

Pick one

  • It adds operator water testing needed

What happend in this PR?

compare water between cpu and gpu
compare water with opencv remap

Signed-off-by: kychennv <kychen@nvidia.com>
Signed-off-by: kychennv <kychen@nvidia.com>
Signed-off-by: kychennv <kychen@nvidia.com>
Signed-off-by: kychennv <kychen@nvidia.com>

def python_water(img):
nh,nw=img.shape[:2]
phase_y=0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put this values in one place as they are used in L27 as well. So we can avoid the risk of changing them in one place only in case this test is reworked.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated now

Copy link
Contributor

@JanuszL JanuszL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment

@JanuszL
Copy link
Contributor

JanuszL commented Aug 2, 2019

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [839680]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [839680]: BUILD FAILED

Signed-off-by: kychennv <kychen@nvidia.com>
@JanuszL
Copy link
Contributor

JanuszL commented Aug 2, 2019

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [839744]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [839744]: BUILD PASSED

@JanuszL JanuszL merged commit c0b65b4 into NVIDIA:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants