Fix pipeline serialization/deserialization for logical_id #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [832631]: BUILD STARTED |
|
CI MESSAGE: [832631]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [832883]: BUILD STARTED |
They start from -1 and are using consecutive negative numbers. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [832926]: BUILD STARTED |
klecki
changed the title
|
CI MESSAGE: [832926]: BUILD PASSED |
JanuszL
approved these changes
Jul 30, 2019
mzient
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Krzysztof Lecki klecki@nvidia.com
Why we need this PR?
Pick one
What happened in this PR?
Pipeline was serialized with assigned logical ids, but internal nodes like MakeContiguous are not serialized (but still get an id). When deserializing, there was collision between new ids for MakeContiguous and old id from serialized pipeline
Now the internal nodes use independent numbering (with negative numbers).
CI
Error message was made verbose.
JIRA Task: [DALI-990]