Parse number of channels in PNGImage::PeekShape #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jantonguirao
changed the title
jantonguirao
changed the title
jantonguirao
force-pushed
the
number_of_channels_in_peek_shape
branch
2 times, most recently
from
b5c8f4e
to
89126a3
Compare
jantonguirao
changed the title
klecki
approved these changes
Sep 25, 2019
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
number_of_channels_in_peek_shape
branch
from
89126a3
to
0786c42
Compare
szalpal
reviewed
Sep 25, 2019
szalpal
approved these changes
Sep 25, 2019
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
number_of_channels_in_peek_shape
branch
from
0786c42
to
823ecc7
Compare
|
!build |
|
CI MESSAGE: [916754]: BUILD STARTED |
|
CI MESSAGE: [916754]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [916897]: BUILD STARTED |
|
CI MESSAGE: [916897]: BUILD PASSED |
00liujj
pushed a commit
to 00liujj/DALI
that referenced
this pull request
Oct 10, 2019
Signed-off-by: Joaquin Anton <janton@nvidia.com> Signed-off-by: Jianjun Liu <00liujj@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
C is hardcoded to 0 in PngImage implementation
What happened in this PR?
Parse number of channels from PNG encoded string
JIRA TASK: [DALI-XXXX]