Allow align-only behavior in Pad operator by treating shape argument as minimum shape #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as minimum shape Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
!build |
|
CI MESSAGE: [1149863]: BUILD STARTED |
|
CI MESSAGE: [1149863]: BUILD PASSED |
mzient
reviewed
Feb 25, 2020
dali/operators/generic/pad.cc
Outdated
| R"code(The extents of the output shape in the axes specified by *axes* or *axis_names*. | ||
| Specifying -1 for an axis restores the default behavior of extending the axis to accommodate the | ||
| (aligned) size of the largest sample in the batch. If the provided extent is smaller than the one | ||
| of the sample, no padding will be applied.)code", |
There was a problem hiding this comment.
Suggested change
| of the sample, no padding will be applied.)code", | |
| of the sample, no padding will be applied (except what is needed to match required alignment).)code", |
mzient
approved these changes
Feb 25, 2020
JanuszL
reviewed
Feb 25, 2020
|
Could you add in the PR description what was the behavior before (or even give some simple example)? |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Done |
|
!build |
|
CI MESSAGE: [1151929]: BUILD STARTED |
|
CI MESSAGE: [1151929]: BUILD PASSED |
JanuszL
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
Pick one, remove the rest
Example:
input shape: [ 4x5, 5x11 ]
axes [1]
align [3]
Old behavior output shape [ 4x12, 5x12 ]
New behavior output shape [4x6, 5x12]
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
What solution was applied:
Changed the meaning of the
shapeargument to be interpreted as minimum shape. That is, if a given sample has a larger shape than the one specified by this argument, no padding shall be applied to that sample. The user can then use shape=(1,) and align=(4,) to achieve per sample alignment without the need to pad all samples to match the shape of the largestAffected modules and functionalities:
Pad operator
Key points relevant for the review:
Pad operator logic and tests
Validation and testing:
Test adjusted, new test case added
Documentation (including examples):
Adjusted documentation of the operator
JIRA TASK: [Use DALI-1280]