Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a leak of the last created DALI pipeline instance #1845

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Mar 30, 2020

  • removes unsused pipeline_tls.prev_pipeline = pipeline that keeps an unnecessary reference to the current pipeline
  • adds test for this case

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • It fixes a leak of the last created DALI pipeline instance

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    removes unsused pipeline_tls.prev_pipeline = pipeline that keeps an unnecessary reference to the current pipeline
  • Affected modules and functionalities:
    pipeline
  • Key points relevant for the review:
    NA
  • Validation and testing:
    test is added
  • Documentation (including examples):
    NA

In response to #1842

JIRA TASK: [NA]

- removes unsused `pipeline_tls.prev_pipeline = pipeline`
  that keeps an unnecessary reference to the current pipeline
- adds test for this case

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Mar 30, 2020

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1221686]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1221686]: BUILD PASSED

@JanuszL JanuszL merged commit 3156c44 into NVIDIA:master Mar 30, 2020
@JanuszL JanuszL deleted the fix_pipeline_ref_count branch March 30, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants