Use true scalars + bug fixes #2318
Conversation
|
!build |
|
CI MESSAGE: [1670444]: BUILD STARTED |
mzient
changed the title
|
!build |
mzient
changed the title
|
This pull request introduces 1 alert when merging 96cd43bf5da7c7fb4e665bf9510e9677b6b9a9c0 into 343fa80 - view on LGTM.com new alerts:
|
|
CI MESSAGE: [1671179]: BUILD STARTED |
|
CI MESSAGE: [1671179]: BUILD FAILED |
|
Please fix LGTM allert. |
dali/python/nvidia/dali/types.py
Outdated
| @@ -349,6 +351,7 @@ def ConstantNode(device, value, dtype, shape, layout, **kwargs): | |||
| def _type_from_value_or_list(v): | |||
| if not isinstance(v, (list, tuple)): | |||
| v = [v] | |||
| shape = [] | |||
There was a problem hiding this comment.
Used in line 403. This was actually a necessary fix.
There was a problem hiding this comment.
Correct me if I'm wrong, but this is the scope of _type_from_value_or_list function and you are not changing the value of the shape variable from the outer scope.
|
!build |
|
CI MESSAGE: [1672075]: BUILD STARTED |
|
This pull request introduces 1 alert when merging 55f710ee75c5c54ba5c987685a5317203fb4607d into 343fa80 - view on LGTM.com new alerts:
|
|
!build |
|
CI MESSAGE: [1672109]: BUILD STARTED |
|
This pull request introduces 1 alert when merging 6cecd8bfc3761380a7dca3e6078b9e0a23f64993 into 343fa80 - view on LGTM.com new alerts:
|
|
!build |
|
CI MESSAGE: [1672239]: BUILD STARTED |
|
This pull request introduces 1 alert when merging 99a7e0d36f347e42524e52e0704a066859a4b535 into 343fa80 - view on LGTM.com new alerts:
|
|
!build |
|
CI MESSAGE: [1672299]: BUILD STARTED |
|
!build |
|
CI MESSAGE: [1672664]: BUILD STARTED |
|
!build |
|
CI MESSAGE: [1672664]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [1673153]: BUILD STARTED |
|
CI MESSAGE: [1673210]: BUILD STARTED |
|
CI MESSAGE: [1673210]: BUILD FAILED |
|
CI MESSAGE: [1672299]: BUILD FAILED |
Fix a bug in executor - attempting to execute subsequent ops in the same stage after a failure. Fix a bug in CocoReader - remove erroneuous assertion. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Allow scalars in slice boundaries. Fix some tests. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Fix CopyWithStrides. Adjust more tests. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Allow scalars in slice boundaries. Fix some tests. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Update scalar shape in arithmetic expression tutorial. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
|
!build |
|
CI MESSAGE: [1674628]: BUILD STARTED |
|
This pull request introduces 1 alert when merging 3ad913037b8877bace307f456e0ee7d513d91edd into ec53d42 - view on LGTM.com new alerts:
|
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
|
CI MESSAGE: [1674628]: BUILD PASSED |
Fix usage of scalars - convert from {1} tensors to {}.
Fix a bug in executor - attempting to execute subsequent ops in the same stage after a failure.
Fix a bug in CocoReader - remove erroneuous assertion.
Classification readers are left out - changing the labels from 1-element tensors to scalars has merit, but I think we might have gone a bit too far there to change it now.
Signed-off-by: Michał Zientkiewicz mzient@gmail.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
JIRA TASK: N/A