Update ExternalSource framework examples #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
!build |
JanuszL
reviewed
Nov 18, 2020
| @@ -24,8 +24,9 @@ | |||
| "import numpy as np\n", | |||
There was a problem hiding this comment.
I think you can jus remove size or set it to -1 so StopIteration will just stop the PyTorchIterator.
Reply via ReviewNB
There was a problem hiding this comment.
When I removed size the iterator ran indefinitely in epoch 0.
|
CI MESSAGE: [1811756]: BUILD STARTED |
|
CI MESSAGE: [1811756]: BUILD FAILED |
|
CI MESSAGE: [1811756]: BUILD PASSED |
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
* use functional API * use modern external source (with source arg) * use more efficient way of reading files * showcase direct usage of PyTorch tensors * use multi-output external source Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
mzient
force-pushed
the
PyTorchExtSrc
branch
from
514597c
to
61f57d7
Compare
mzient
changed the title
mzient
commented
Nov 19, 2020
Comment on lines
+439
to
+440
| template class DLL_PUBLIC TensorVector<CPUBackend>; | ||
| template class DLL_PUBLIC TensorVector<GPUBackend>; |
There was a problem hiding this comment.
Without it debug build with Clang 6 didn't link properly.
|
!build |
|
CI MESSAGE: [1814371]: BUILD STARTED |
jantonguirao
approved these changes
Nov 19, 2020
|
CI MESSAGE: [1814371]: BUILD PASSED |
banasraf
approved these changes
Nov 19, 2020
JanuszL
reviewed
Nov 19, 2020
| @@ -15,7 +15,7 @@ | |||
| }, | |||
| { | |||
| "cell_type": "code", | |||
| "execution_count": 1, | |||
| "execution_count": 5, | |||
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
JanuszL
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michał Zientkiewicz mzient@gmail.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
JIRA TASK: N/A