-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ExternalSource framework examples #2482
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
!build |
@@ -24,8 +24,9 @@ | |||
"import numpy as np\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can jus remove size or set it to -1 so StopIteration
will just stop the PyTorchIterator.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I removed size the iterator ran indefinitely in epoch 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mhhh, strange
CI MESSAGE: [1811756]: BUILD STARTED |
CI MESSAGE: [1811756]: BUILD FAILED |
CI MESSAGE: [1811756]: BUILD PASSED |
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
* use functional API * use modern external source (with source arg) * use more efficient way of reading files * showcase direct usage of PyTorch tensors * use multi-output external source Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
514597c
to
61f57d7
Compare
template class DLL_PUBLIC TensorVector<CPUBackend>; | ||
template class DLL_PUBLIC TensorVector<GPUBackend>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without it debug build with Clang 6 didn't link properly.
!build |
CI MESSAGE: [1814371]: BUILD STARTED |
CI MESSAGE: [1814371]: BUILD PASSED |
@@ -15,7 +15,7 @@ | |||
}, | |||
{ | |||
"cell_type": "code", | |||
"execution_count": 1, | |||
"execution_count": 5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michał Zientkiewicz mzient@gmail.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
JIRA TASK: N/A