-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race condition in NemoAsrReader when pad_last_batch is set to True #2828
Fix race condition in NemoAsrReader when pad_last_batch is set to True #2828
Conversation
pipe.build() | ||
# Checking that the decoding doesn't fail due to race conditions | ||
for _ in range(10): | ||
outs = pipe.run() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check the outs
result if you really get the desired number of unique samples, and the right sample is repeated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Joaquin Anton <janton@nvidia.com>
1f68968
to
d54811e
Compare
!build |
CI MESSAGE: [2221796]: BUILD STARTED |
CI MESSAGE: [2221885]: BUILD STARTED |
CI MESSAGE: [2221885]: BUILD FAILED |
CI MESSAGE: [2221930]: BUILD STARTED |
CI MESSAGE: [2221796]: BUILD PASSED |
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Detect repeated samples and only decode once
readers.nemo_asr
NA
Test added
NA
JIRA TASK: [DALI-1942]