Fix race condition in NemoAsrReader when pad_last_batch is set to True #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanuszL
reviewed
Mar 30, 2021
| pipe.build() | ||
| # Checking that the decoding doesn't fail due to race conditions | ||
| for _ in range(10): | ||
| outs = pipe.run() |
There was a problem hiding this comment.
Can you check the outs result if you really get the desired number of unique samples, and the right sample is repeated?
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
nemo_asr_pad_last_batch_fix
branch
from
1f68968
to
d54811e
Compare
JanuszL
approved these changes
Mar 31, 2021
|
!build |
|
CI MESSAGE: [2221796]: BUILD STARTED |
|
CI MESSAGE: [2221885]: BUILD STARTED |
|
CI MESSAGE: [2221885]: BUILD FAILED |
|
CI MESSAGE: [2221930]: BUILD STARTED |
|
CI MESSAGE: [2221796]: BUILD PASSED |
banasraf
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Detect repeated samples and only decode once
readers.nemo_asr
NA
Test added
NA
JIRA TASK: [DALI-1942]