-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert pruning of unused architectures #4336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- there is a copy-paste typo in pruning commands for CUDA 11.8 for SBSA - in CUDA 10.2 only PTX for arch 70 is left while many libraries delivers PRX for the latest arch available - 75 and in the result the GPU code fails to run on anything newer than sm_70 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
CI MESSAGE: [6158860]: BUILD STARTED |
CI MESSAGE: [6158861]: BUILD STARTED |
…NVIDIA#4317)" This reverts commit a507066.
JanuszL
changed the title
Fix pruning unintended PTX versions
Revert pruning of unused architectures
Oct 12, 2022
CI MESSAGE: [6161546]: BUILD STARTED |
CI MESSAGE: [6161553]: BUILD STARTED |
CI MESSAGE: [6161546]: BUILD FAILED |
CI MESSAGE: [6161546]: BUILD PASSED |
CI MESSAGE: [6161553]: BUILD FAILED |
CI MESSAGE: [6161553]: BUILD PASSED |
jantonguirao
approved these changes
Oct 13, 2022
mzient
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is no way to prune cubins for selected
architectures and keep ptx
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
there is no way to prune cubins for selected
architectures and keep ptx
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A