Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pruning of unused architectures #4336

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Oct 12, 2022

  • reverts pruning of unused architectures as
    there is no way to prune cubins for selected
    architectures and keep ptx

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

  • reverts pruning of unused architectures as
    there is no way to prune cubins for selected
    architectures and keep ptx

Additional information:

Affected modules and functionalities:

  • docker files

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

- there is a copy-paste typo in pruning commands for
  CUDA 11.8 for SBSA
- in CUDA 10.2 only PTX for arch 70 is left while many libraries
  delivers PRX for the latest arch available - 75 and in the result
  the GPU code fails to run on anything newer than sm_70

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6158860]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6158861]: BUILD STARTED

@JanuszL JanuszL changed the title Fix pruning unintended PTX versions Revert pruning of unused architectures Oct 12, 2022
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6161546]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6161553]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6161546]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6161546]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6161553]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6161553]: BUILD PASSED

@JanuszL JanuszL merged commit 5687ecb into NVIDIA:main Oct 13, 2022
@JanuszL JanuszL deleted the keep_ptx branch October 13, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants