-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure that lossless support is disabled when it fails to initialize #4934
Conversation
CI MESSAGE: [8818540]: BUILD FAILED |
CI MESSAGE: [8818771]: BUILD STARTED |
CI MESSAGE: [8818771]: BUILD FAILED |
ffd7eb0
to
fde7100
Compare
CI MESSAGE: [8824496]: BUILD FAILED |
CI MESSAGE: [8824757]: BUILD FAILED |
CI MESSAGE: [8824757]: BUILD STARTED |
fde7100
to
07b3660
Compare
CI MESSAGE: [8912748]: BUILD STARTED |
CI MESSAGE: [8912748]: BUILD FAILED |
07b3660
to
15b4d63
Compare
CI MESSAGE: [8913650]: BUILD STARTED |
15b4d63
to
89c3d6e
Compare
CI MESSAGE: [8915274]: BUILD STARTED |
CI MESSAGE: [8915274]: BUILD FAILED |
89c3d6e
to
c7a4b73
Compare
CI MESSAGE: [8921621]: BUILD STARTED |
CI MESSAGE: [8921621]: BUILD FAILED |
c7a4b73
to
61a820c
Compare
CI MESSAGE: [8927414]: BUILD STARTED |
CI MESSAGE: [8927414]: BUILD FAILED |
61a820c
to
b3a07e5
Compare
CI MESSAGE: [8929466]: BUILD STARTED |
CI MESSAGE: [8929466]: BUILD FAILED |
b3a07e5
to
4ac24ae
Compare
CI MESSAGE: [8933095]: BUILD STARTED |
CI MESSAGE: [8933097]: BUILD STARTED |
CI MESSAGE: [8933095]: BUILD FAILED |
CI MESSAGE: [8933097]: BUILD FAILED |
4ac24ae
to
f8e3e06
Compare
CI MESSAGE: [8942963]: BUILD STARTED |
CI MESSAGE: [8942963]: BUILD FAILED |
828b068
to
9f9c87d
Compare
CI MESSAGE: [8944124]: BUILD STARTED |
- older versions on nvJPEG don't support lossless JPEG, so when such one is used make sure it is disabled Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
9f9c87d
to
0a9e825
Compare
CI MESSAGE: [8945257]: BUILD STARTED |
CI MESSAGE: [8944124]: BUILD FAILED |
CI MESSAGE: [8944124]: BUILD PASSED |
CI MESSAGE: [8945257]: BUILD FAILED |
CI MESSAGE: [8945257]: BUILD PASSED |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
// some nvJPEG version doesn't support NVJPEG_BACKEND_LOSSLESS_JPEG so disable it if | ||
// it failed to initialize | ||
DALI_WARN_ONCE("The available nvJPEG library version doesn't support Lossless format, please " | ||
" update to the latest one."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
" update to the latest one."); | |
"update to the latest one."); |
You already have a space in the previous line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@@ -25,6 +25,11 @@ | |||
#include "dali/core/cuda_error.h" | |||
#include "dali/core/format.h" | |||
|
|||
#if WITH_DYNAMIC_NVJPEG_ENABLED | |||
bool nvjpegIsSymbolAvailable(const char *name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't seem to be using this in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
CI MESSAGE: [8996798]: BUILD STARTED |
CI MESSAGE: [8996798]: BUILD FAILED |
CI MESSAGE: [8996798]: BUILD PASSED |
…ze (NVIDIA#4934) - older versions on nvJPEG don't support lossless JPEG, so when such one is used make sure it is disabled Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
so when such one is used make sure it is disabled
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
so when such one is used make sure it is disabled
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A