Fix wheel bundling with cvcuda for debug builds #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banasraf
force-pushed
the
fix-debug-wheel-bundling
branch
from
9090031
to
4f938ee
Compare
|
CI MESSAGE: [9175202]: BUILD STARTED |
banasraf
force-pushed
the
fix-debug-wheel-bundling
branch
from
4f938ee
to
a204701
Compare
|
CI MESSAGE: [9175202]: BUILD FAILED |
Signed-off-by: Rafal Banas <rbanas@nvidia.com>
banasraf
force-pushed
the
fix-debug-wheel-bundling
branch
from
a204701
to
f6c1066
Compare
|
CI MESSAGE: [9175793]: BUILD STARTED |
szalpal
reviewed
Jul 31, 2023
dali/python/bundle-wheel.sh
Outdated
Comment on lines
127
to
128
| "lib/libcvcuda_d.so.0" # debug build | ||
| "lib/libnvcv_types_d.so.0" # debug build |
There was a problem hiding this comment.
May I ask for making this comment more descriptive?
There was a problem hiding this comment.
# cvcuda adds _d suffix to lib names for debug builds
"lib/libcvcuda_d.so.0"
"lib/libnvcv_types_d.so.0"descriptive enough?
|
CI MESSAGE: [9175793]: BUILD PASSED |
Signed-off-by: Rafal Banas <rbanas@nvidia.com>
|
CI MESSAGE: [9189881]: BUILD STARTED |
jantonguirao
approved these changes
Aug 1, 2023
szalpal
approved these changes
Aug 1, 2023
|
CI MESSAGE: [9189881]: BUILD PASSED |
JanuszL
pushed a commit
to JanuszL/DALI
that referenced
this pull request
Oct 13, 2023
Signed-off-by: Rafal Banas <rbanas@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes wheel bundling for debug builds with cv-cuda.
Category:
Other
Description:
I fixes CI
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A