Fix race condition in checkpointing test #4983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Staniewski <mstaniewski@nvidia.com>
|
!build |
JanuszL
approved these changes
Aug 7, 2023
|
CI MESSAGE: [9267862]: BUILD STARTED |
stiepan
approved these changes
Aug 7, 2023
|
CI MESSAGE: [9267862]: BUILD PASSED |
stiepan
pushed a commit
that referenced
this pull request
Aug 8, 2023
This PR fixes issue in the DataReader checkpointing tests. The problem is, that the checkpoint was created before running the corresponding epoch, but the state snapshot is created along with the first iteration of an epoch. When prefetching did not run fast enough, the test failed. Signed-off-by: Michał Staniewski <mstaniewski@nvidia.com>
JanuszL
pushed a commit
to JanuszL/DALI
that referenced
this pull request
Oct 13, 2023
This PR fixes issue in the DataReader checkpointing tests. The problem is, that the checkpoint was created before running the corresponding epoch, but the state snapshot is created along with the first iteration of an epoch. When prefetching did not run fast enough, the test failed. Signed-off-by: Michał Staniewski <mstaniewski@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
This PR fixes issue in the DataReader checkpointing tests.
The problem is, that the checkpoint was created before running the corresponding epoch, but the state snapshot is created along with the first iteration of an epoch. When prefetching did not run fast enough, the test failed.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A