Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim CV-CUDA to expose only median blur to reduce the binary size #4985

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Aug 8, 2023

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • trims CV-CUDA to expose only median blur to reduce the binary size (as CV-CUDA adds 100 MB to the build)

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • test_median_blur.py
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9286200]: BUILD STARTED

@stiepan stiepan self-assigned this Aug 8, 2023
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9286200]: BUILD FAILED

@klecki klecki assigned klecki and unassigned awolant Aug 8, 2023
@klecki
Copy link
Contributor

klecki commented Aug 8, 2023

I would be happy if we could come up with a workflow that just tracks the native CV-CUDA repo rather than using our fork.

@JanuszL
Copy link
Contributor Author

JanuszL commented Aug 8, 2023

I would be happy if we could come up with a workflow that just tracks the native CV-CUDA repo rather than using our fork.

Me too. For now, we are still at the very early stage of integration and we require more rapid updates than the CV-CUDA release cycle provides.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9286790]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9286790]: BUILD PASSED

@JanuszL JanuszL merged commit f48c03b into NVIDIA:main Aug 8, 2023
4 checks passed
@JanuszL JanuszL deleted the reduce_cv_cuda_size branch August 8, 2023 18:08
JanuszL added a commit that referenced this pull request Aug 8, 2023
)

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL added a commit to JanuszL/DALI that referenced this pull request Oct 13, 2023
…IDIA#4985)

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants