Make sure that the right version of libabseil is used in conda #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DALI links statically with libprotobuf and this implies a runtime dependency on libabseil in a conda environment. However, it seems that protobuf cmake asks DALI to link with a specific (versioned) libabseil instead of just *.so, and when a newer libabseil than the libprotobuf was built with appeared there is an error and during the installation, DALI asks for the latest libabseil while libprotobuf enforces a certain version. This PR makes sure that the libprotobuf installs its dependencies with DALI without explicit placing libabseil in the runtime dependency list Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [9300798]: BUILD STARTED |
|
CI MESSAGE: [9300798]: BUILD PASSED |
awolant
approved these changes
Aug 10, 2023
szalpal
approved these changes
Aug 10, 2023
JanuszL
added a commit
to JanuszL/DALI
that referenced
this pull request
Aug 11, 2023
…used in conda - relates to NVIDIA#4987 - DALI conda build depends on libprotobuf-static and protobuf. The first was just recently updated while the latter was not, so during the build the libabseil version is older and implied by protobuf, why during runtime libprotobuf-static picks the newer one. Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
18 tasks
JanuszL
added a commit
that referenced
this pull request
Aug 11, 2023
…used in conda (#4991) - relates to #4987 - DALI conda build depends on libprotobuf-static and protobuf. The first was just recently updated while the latter was not, so during the build the libabseil version is older and implied by protobuf, why during runtime libprotobuf-static picks the newer one. Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
added a commit
to JanuszL/DALI
that referenced
this pull request
Oct 13, 2023
…A#4987) - DALI links statically with libprotobuf and this implies a runtime dependency on libabseil in a conda environment. However, it seems that protobuf cmake asks DALI to link with a specific (versioned) libabseil instead of just *.so, and when a newer libabseil than the libprotobuf was built with appeared there is an error and during the installation, DALI asks for the latest libabseil while libprotobuf enforces a certain version. This PR makes sure that the libprotobuf installs its dependencies with DALI without explicit placing libabseil in the runtime dependency list Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
added a commit
to JanuszL/DALI
that referenced
this pull request
Oct 13, 2023
…used in conda (NVIDIA#4991) - relates to NVIDIA#4987 - DALI conda build depends on libprotobuf-static and protobuf. The first was just recently updated while the latter was not, so during the build the libabseil version is older and implied by protobuf, why during runtime libprotobuf-static picks the newer one. Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependency on libabseil in a conda environment. However, it seems
that protobuf cmake asks DALI to link with a specific (versioned)
libabseil instead of just *.so, and when a newer libabseil than
the libprotobuf was built with appeared there is an error
and during the installation, DALI asks for the latest libabseil
while libprotobuf enforces a certain version. This PR makes sure
that the libprotobuf installs its dependencies with DALI without
explicit placing libabseil in the runtime dependency list
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
dependency on libabseil in a conda environment. However, it seems
that protobuf cmake asks DALI to link with a specific (versioned)
libabseil instead of just *.so, and when a newer libabseil than
the libprotobuf was built with appeared there is an error
and during the installation, DALI asks for the latest libabseil
while libprotobuf enforces a certain version. This PR makes sure
that the libprotobuf installs its dependencies with DALI without
explicit placing libabseil in the runtime dependency list
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A