Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different way to ensure that the right version of libabseil is used in conda #4991

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Aug 11, 2023

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

Additional information:

Affected modules and functionalities:

  • conda recipe

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • all conda tests
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

…used in conda

- relates to NVIDIA#4987
- DALI conda build depends on libprotobuf-static and protobuf. The first
  was just recently updated while the latter was not, so during the build
  the libabseil version is older and implied by protobuf, why during runtime
  libprotobuf-static picks the newer one.

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9332698]: BUILD STARTED

@stiepan stiepan self-assigned this Aug 11, 2023
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9332698]: BUILD PASSED

@awolant awolant self-assigned this Aug 11, 2023
@JanuszL JanuszL merged commit 2c49a65 into NVIDIA:main Aug 11, 2023
4 checks passed
@JanuszL JanuszL deleted the more_conda_fixes branch August 11, 2023 20:36
@JanuszL JanuszL changed the title Use different a way to ensure that the right version of libabseil is used in conda Use a different way to ensure that the right version of libabseil is used in conda Aug 11, 2023
JanuszL added a commit to JanuszL/DALI that referenced this pull request Oct 13, 2023
…used in conda (NVIDIA#4991)

- relates to NVIDIA#4987
- DALI conda build depends on libprotobuf-static and protobuf. The first
  was just recently updated while the latter was not, so during the build
  the libabseil version is older and implied by protobuf, why during runtime
  libprotobuf-static picks the newer one.

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants