Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python op tutorial #5120

Merged
merged 11 commits into from
Oct 27, 2023
Merged

Conversation

awolant
Copy link
Contributor

@awolant awolant commented Oct 25, 2023

Category:

Refactoring

Description:

Remove outdated info from Python Op doc, move it to decorator API.

Additional information:

Affected modules and functionalities:

Python op tutorial.

Key points relevant for the review:

Is it correct?

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
@banasraf banasraf self-assigned this Oct 25, 2023
@review-notebook-app
Copy link

review-notebook-app bot commented Oct 25, 2023

View / edit / reply to this conversation on ReviewNB

banasraf commented on 2023-10-25T08:24:59Z
----------------------------------------------------------------

Please change the names of the operators to fn API (PythonFunctinon -> python_function etc.)


awolant commented on 2023-10-25T09:38:56Z
----------------------------------------------------------------

Done

Signed-off-by: Albert Wolant <awolant@nvidia.com>
Copy link
Contributor Author

awolant commented Oct 25, 2023

Done


View entire conversation on ReviewNB

@awolant
Copy link
Contributor Author

awolant commented Oct 26, 2023

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [10450153]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [10450153]: BUILD PASSED

@awolant awolant merged commit 4a32bd0 into NVIDIA:main Oct 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants