Refactor detection pipeline test #693
Conversation
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
| ltrb=True, | ||
| random_shuffle=True) | ||
|
|
||
| self.decode_cpu = ops.HostDecoder(device="cpu", output_type=types.RGB) |
There was a problem hiding this comment.
do you need two decoders?
There was a problem hiding this comment.
The idea of this test is to check different ways of doing the same thing against each other.
There was a problem hiding this comment.
Theoretically we can go with CPU one and then transfer to the GPU for the GPU ops. But I agree with @awolant.
There was a problem hiding this comment.
I wanted to test corresponding ops on the same exact data, so this pipeline is rather not optimized.
| if __name__ == "__main__": | ||
| parser = make_parser() | ||
| args = parser.parse_args() | ||
| args.batch_size = 1 | ||
|
|
There was a problem hiding this comment.
are there any expected results in this test?
There was a problem hiding this comment.
If exit(1) is not called, that indicates success. I did not change that from previous version.
There was a problem hiding this comment.
In case of crash non 0 value is returned as well, or am I wrong?
There was a problem hiding this comment.
Yes, it should be set to something other than 0
awolant
force-pushed
the
refactor_detection_pipeline_test
branch
from
b26e21d
to
12f2766
Compare
Signed-off-by: Albert Wolant <awolant@nvidia.com>
awolant
force-pushed
the
refactor_detection_pipeline_test
branch
from
12f2766
to
d784c0a
Compare
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
|
Build 686182 |
Refactor of detection pipeline test. Added all operators from detection pipeline. Added tests against reference implementations for some of them. Signed-off-by: Albert Wolant <awolant@nvidia.com>
Refactored detection pipeline test. Added more ops to it.