[WIP] Release buffers in separeted executor after it is processed #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Separated Executor error: Mixed stage was releasing CPU outputs (marking them as free), but they might still be in use as Mixed can work in asynchronous manner on a stream. Now we release all the output buffers (as free) from the stages only when we know all the processing was finished and data was consumed properly. This release can be done as soon as we synchronize GPU for ShareOutputs call. Another possible solution is to put a callback on a stream that will release the buffers as soon as they are consumed Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
klecki
force-pushed
the
fix-separate-exec
branch
from
60a5898
to
6779247
Compare
|
#712 will be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Separated Executor error:
Mixed stage was releasing CPU outputs (marking them as free),
but they might still be in use as Mixed can work in
asynchronous manner on a stream.
Now we release all the output buffers (as free) from the stages
only when we know all the processing was finished and data was
consumed properly.
This release can be done as soon as we synchronize
GPU for ShareOutputs call.
Another possible solution is to put a callback on a stream
that will release the buffers as soon as they are consumed
Signed-off-by: Krzysztof Lecki klecki@nvidia.com