Mark stage buffers as consumed with stream callback #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kh4L
approved these changes
Apr 1, 2019
JanuszL
reviewed
Apr 1, 2019
| if (HasPreviousStage(stage)) { | ||
| ReleaseStageIdx(PreviousStage(stage), idxs); | ||
| } | ||
| // TODO(klecki) when we move to CUDA 10, we should move to cudaLaunchHostFunc |
There was a problem hiding this comment.
Maybe ifdef for CUDA 10? We have CUDA 10 already.
There was a problem hiding this comment.
This API is described as to be deprecated in some future, but is still available in both CUDA 9 and 10. Maybe it is better to not have build dependent code paths until we actually need to.
JanuszL
approved these changes
Apr 1, 2019
jantonguirao
reviewed
Apr 1, 2019
jantonguirao
approved these changes
Apr 1, 2019
|
Build 692185. |
|
Rebased on #699, to reduce the CI workload. |
klecki
force-pushed
the
callback-release
branch
3 times, most recently
from
1073488
to
b6523f5
Compare
|
Proper changes only in last commit, rest is #699 |
This fixes an issue of marking CPU buffers as free before they are consumed by async GPU kernels of Mixed stage (simialr thing for Support stage). Short circuit ReleaseIdx for invalid idxs Introduce kInvalidIdx in queue policy Check if indexes are valid before processing Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
Build 693777 |
haoxintong
pushed a commit
to haoxintong/DALI
that referenced
this pull request
Jul 16, 2019
This fixes an issue of marking CPU buffers as free before they are consumed by async GPU kernels of Mixed stage (simialr thing for Support stage). Short circuit ReleaseIdx for invalid idxs Introduce kInvalidIdx in queue policy Check if indexes are valid before processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue of marking CPU buffers as free
before they are consumed by async GPU kernels
of Mixed stage (simialr thing for Support stage).
Alternative to #708.
Signed-off-by: Krzysztof Lecki klecki@nvidia.com