Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One user can see other user's jobs #1221

Open
JulyUp opened this issue Oct 27, 2016 · 4 comments
Open

One user can see other user's jobs #1221

JulyUp opened this issue Oct 27, 2016 · 4 comments

Comments

@JulyUp
Copy link

JulyUp commented Oct 27, 2016

Hello, I login in digits using a user name 'A' and do some jobs. But when I login in digits using other user name 'B', I can see A's jobs. In addition, There is no password function when logging.
So should this user login management be improved?

@lukeyeager
Copy link
Member

This is what we have implemented: #463

Your request is a duplicate of: #407

@JulyUp
Copy link
Author

JulyUp commented Dec 22, 2016

@lukeyeager Although one user can not edit and delete other users' jobs, but still can see other users' jobs in the newest version. I feel it will be greater if we can not see others' jobs.
In addition, I try to add the 'password' function but do not success. It seems not to be a little work.

@lukeyeager
Copy link
Member

Oh you're right - I was too quick to tag this as a duplicate. Sorry.

This could be a simple UI change on the front-page:

  • Show running jobs from all users (you can only abort/delete them if they're yours)
  • Show only your own completed jobs

@JulyUp
Copy link
Author

JulyUp commented Jan 4, 2017

@lukeyeager Thank your response. I have realized this function and can only show my own jobs through modifying the digits/views.py.
And I am learning to add the register and login in function with email and password from @miguelgrinberg 's flasky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants