-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic login functionality #463
Conversation
/cc @jmancewicz |
What are you doing with existing jobs? |
They are marked with |
Perfect |
Need to fix the test suite before merging... |
How do I clone the repository to get this functionality or enable it? I've already cloned the master expecting it would be there. |
@iwalkdaline this is an unmerged pull request - it hasn't been merged into If you really want to try it out for some reason, the git commands would be something like this:
|
We really want some form of authentication on our server. I was pursuing a Ivan Walker On Mon, Jan 4, 2016 at 1:04 PM, Luke Yeager notifications@github.com
|
1e79ab9
to
706e620
Compare
It's unable to handle decorated functions which we need for login/auth
52273d1
to
0cbf936
Compare
Update testsuite to match
Update on this - I had to remove all the Flask-Autodoc stuff in order to add custom route decorators. I suspect nobody was using the auto-generated documentation anyway. If so, we'll find a way to add it back in somehow. |
@iwalkdaline I'm going to merge this as-is. We're not going to address authentication in DIGITS for now, but the scaffolding that I'm putting in place with this PR should make it easier for you to modify DIGITS to add authentication on your own. Please feel free to upvote (:+1:) #407 if you like. |
I see. Also, I'm trying to add a password field and I think this will
I've tried so far but get the error that password isn't defined globally.
|
Add basic login functionality
Close #201
TODO after merge
/models