Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic login functionality #463

Merged
merged 3 commits into from
Jan 7, 2016
Merged

Add basic login functionality #463

merged 3 commits into from
Jan 7, 2016

Conversation

lukeyeager
Copy link
Member

Close #201

  • Login does not require password (not solving Digits UI with Authentication #407)
  • Adds login info to the navbar
  • Requires login before creating a new Job
  • Only the original creator can abort/edit/delete a Job

after-login

TODO after merge

  • Sort/filter by username in model browser at /models
  • Show only the current user's jobs on the homepage

@lukeyeager
Copy link
Member Author

/cc @jmancewicz

@lukeyeager lukeyeager mentioned this pull request Dec 10, 2015
@jmancewicz
Copy link
Contributor

What are you doing with existing jobs?

@lukeyeager
Copy link
Member Author

What are you doing with existing jobs?

They are marked with job.username=None. Any logged in user can edit/delete them.

@jmancewicz
Copy link
Contributor

Perfect

@lukeyeager
Copy link
Member Author

Need to fix the test suite before merging...

@lukeyeager lukeyeager self-assigned this Dec 14, 2015
@iwalkdaline
Copy link

How do I clone the repository to get this functionality or enable it? I've already cloned the master expecting it would be there.

@lukeyeager
Copy link
Member Author

@iwalkdaline this is an unmerged pull request - it hasn't been merged into master yet. You should probably just wait until we merge it.

If you really want to try it out for some reason, the git commands would be something like this:

git remote add lukeyeager https://github.com/lukeyeager/DIGITS.git
git remote update
git checkout lukeyeager/login

@iwalkdaline
Copy link

We really want some form of authentication on our server. I was pursuing a
SSL approach with a self-signed certificate but that required slightly more
work than I anticipated. As this is implemented, I would proceed with it
unless there's some corner case I should be aware of.


Ivan Walker
(601)918-0435
Graduate Student
GVU BrainLab
Georgia Institute of Technology
Atlanta, GA 30032 USA

On Mon, Jan 4, 2016 at 1:04 PM, Luke Yeager notifications@github.com
wrote:

@iwalkdaline https://github.com/iwalkdaline this is an unmerged pull
request - it hasn't been merged into master yet. You should probably just
wait until we merge it.

If you really want to try it out for some reason, the git commands would
be something like this:

git remote add lukeyeager https://github.com/lukeyeager/DIGITS.git
git remote update
git checkout lukeyeager/login


Reply to this email directly or view it on GitHub
#463 (comment).

It's unable to handle decorated functions which we need for login/auth
@lukeyeager
Copy link
Member Author

Update on this - I had to remove all the Flask-Autodoc stuff in order to add custom route decorators.

I suspect nobody was using the auto-generated documentation anyway. If so, we'll find a way to add it back in somehow.

@lukeyeager
Copy link
Member Author

@iwalkdaline I'm going to merge this as-is. We're not going to address authentication in DIGITS for now, but the scaffolding that I'm putting in place with this PR should make it easier for you to modify DIGITS to add authentication on your own.

Please feel free to upvote (:+1:) #407 if you like.

@iwalkdaline
Copy link

I see. Also, I'm trying to add a password field and I think this will
address my needs but not sure of the data flow here. Seems I might need to

  1. add it webapp.py (in username decorator or a new decorator)
  2. add it to auth.py to verify the password
  3. modify views.py

I've tried so far but get the error that password isn't defined globally.

  • Ivan

lukeyeager added a commit that referenced this pull request Jan 7, 2016
Add basic login functionality
@lukeyeager lukeyeager merged commit 3da31c7 into NVIDIA:master Jan 7, 2016
@lukeyeager lukeyeager deleted the login branch January 7, 2016 17:55
@lukeyeager lukeyeager mentioned this pull request Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants