Add ability to clone previous jobs #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmancewicz
force-pushed
the
clone
branch
2 times, most recently
from
2046ad9
to
62629d4
Compare
|
Added tests for cloning the four creating pages. @lukeyeager can you have a look? |
|
Sure, I'll take a look. But you've got 5 test failures that need resolving before a merge. |
| @@ -115,6 +115,10 @@ def create_dataset(cls, **kwargs): | |||
| if request_json: | |||
| url += '.json' | |||
|
|
|||
| clone = data.pop('clone', None) | |||
| if clone is not None: | |||
| url += '?clone=' + clone | |||
There was a problem hiding this comment.
I thought we said this was going to work for POST data as well as query string arguments? Why is this necessary?
There was a problem hiding this comment.
Are you asking did I put it into data?
jmancewicz
force-pushed
the
clone
branch
2 times, most recently
from
7845805
to
a55a0ec
Compare
jmancewicz
force-pushed
the
clone
branch
4 times, most recently
from
8242f2f
to
5f681be
Compare
|
This looks good to me. Let's squash into a single commit and merge. |
jmancewicz
added a commit
that referenced
this pull request
Oct 23, 2015
Add ability to clone previous jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A 'Clone Job' button has been added to the Job pages.
The approach I took was to save the form settings when a job starts for each Field (except SubmitField and FileField in a dict() on the job called form_data.
When a job is cloned, the form is created and populated with the saved form_data from the source job. If a field in the form can not be populated with saved form_data, a warning is presented at the head of the document.
I put the 'Clone Job' button to the left of the 'Abort Job' button.
I'd don't love this. When the Job completes, the 'Abort Job' disappears and the Clone moves to where the Abort Job had been, and could fire a Clone when the user means to Abort. Also, if the source job does not have form_data, the 'Clone Job' button is disabled rather then hidden. I'm not sure I feel is better.
I need to make a test for the suite, but prefer to get this out as is for comment.
I changed the print_errors macro to also print warnings and added a hl_errors macro to add has-error and has-warning classes.