Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove createParams* functions. #2254

Merged
merged 13 commits into from
Jun 3, 2024
Merged

Remove createParams* functions. #2254

merged 13 commits into from
Jun 3, 2024

Conversation

wujingyue
Copy link
Collaborator

Their definitions are therefore inlined for conciseness and less indirection.

@wujingyue
Copy link
Collaborator Author

!build --dist

samnordmann
samnordmann approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@samnordmann samnordmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Also my_device_index shouldn't be needed before posting the collective at runtime

@wujingyue
Copy link
Collaborator Author

!build

@wujingyue
Copy link
Collaborator Author

!build

@wujingyue
Remove createParams* functions.
48561c6 
Their definitions are therefore inlined for conciseness and less
indirection.
@wujingyue
Fix a pre-existing bug.
49874b8
@wujingyue
Remove CommunicationTest::params.
cd6cfe7
@wujingyue
Copy link
Collaborator Author

!build

Base automatically changed from wjy/comm to main June 3, 2024 05:08
@wujingyue
Copy link
Collaborator Author

!build

@wujingyue
Copy link
Collaborator Author

!build

@wujingyue wujingyue merged commit 5b71b56 into main Jun 3, 2024
14 of 17 checks passed
@wujingyue wujingyue deleted the wjy/param branch June 3, 2024 18:26
zasdfgbnm pushed a commit that referenced this pull request Jun 5, 2024
@wujingyue @zasdfgbnm
Remove createParams* functions. (#2254)
23c52dd 
Their definitions are therefore inlined for conciseness and less
indirection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samnordmann samnordmann samnordmann approved these changes

@cowanmeg cowanmeg Awaiting requested review from cowanmeg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wujingyue @samnordmann