Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI failure #2590

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix CI failure #2590

merged 1 commit into from
May 23, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented May 22, 2024 •
edited

For PR #2563, the Jenkins CI is failing all the time

Description

  1. Follows pytest-xdist workers crashing  coiled/benchmarks#404 to reduce the number of parallel workers to reduce the problem
  2. upgrade the pytest version

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh
Copy link
Collaborator Author

/build

5 similar comments
@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh changed the title [DRAFT] Try Fix CI failure May 22, 2024
@YuanTingHsieh YuanTingHsieh added the cicd continuous integration/continuous development label May 22, 2024
chesterxgchen
chesterxgchen approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chesterxgchen chesterxgchen merged commit b3abf1f into NVIDIA:main May 23, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the try_something branch May 23, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

@holgerroth holgerroth Awaiting requested review from holgerroth

Assignees
No one assigned
Labels
cicd continuous integration/continuous development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YuanTingHsieh @chesterxgchen