Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API for Pythonic Job Creation #2563

Merged
merged 39 commits into from May 23, 2024
Merged

Add API for Pythonic Job Creation #2563

merged 39 commits into from May 23, 2024

Conversation

holgerroth
Copy link
Collaborator

@holgerroth holgerroth commented May 6, 2024 •
edited

Fixes # .

Description

  • Adds API for Pythonic Job Creation
  • FedJob allows users to generate job configurations in a Pythonic way. The to() routine allows users to send different components to either the server or clients.
  • Adds the first set of examples utilizing Job API
  • More tutorials to follow

Depends on #2578

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

holgerroth
holgerroth commented May 7, 2024
View reviewed changes
nvflare/fed_job.py Outdated Show resolved Hide resolved
@holgerroth holgerroth requested a review from SYangster May 7, 2024 20:36
yhwen
yhwen reviewed May 8, 2024
View reviewed changes
nvflare/fed_job.py Outdated Show resolved Hide resolved
nvflare/fed_job.py Outdated Show resolved Hide resolved
nvflare/fed_job.py Outdated Show resolved Hide resolved
nvflare/fed_job.py Outdated Show resolved Hide resolved
YuanTingHsieh
YuanTingHsieh reviewed May 8, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great examples, Some comments

nvflare/app_common/executors/script_executor.py Outdated Show resolved Hide resolved
nvflare/fed_job.py Outdated Show resolved Hide resolved
nvflare/fed_job.py Outdated Show resolved Hide resolved
nvflare/app_common/executors/model_learner_executor.py Outdated Show resolved Hide resolved
examples/hello-world/job_api/pt/src/kmeans_fl.py Outdated Show resolved Hide resolved
examples/hello-world/job_api/pt/src/kmeans_assembler.py Outdated Show resolved Hide resolved
examples/hello-world/job_api/pt/src/__init__.py Outdated Show resolved Hide resolved
examples/hello-world/job_api/pt/client_api_kmeans.py Outdated Show resolved Hide resolved
examples/hello-world/job_api/pt/model_learner_xsite_val.py Outdated Show resolved Hide resolved
chesterxgchen
chesterxgchen previously approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, there are few topics we will think about how to address later.

@holgerroth
Copy link
Collaborator Author

/build

@holgerroth holgerroth enabled auto-merge (squash) May 17, 2024 20:35
@holgerroth holgerroth mentioned this pull request May 17, 2024
Open
@holgerroth
Copy link
Collaborator Author

/build

1 similar comment
@holgerroth
Copy link
Collaborator Author

/build

@holgerroth
Copy link
Collaborator Author

/build

1 similar comment
@holgerroth
Copy link
Collaborator Author

/build

@holgerroth holgerroth disabled auto-merge May 21, 2024 16:19
@YuanTingHsieh
Copy link
Collaborator

/build

@holgerroth
Copy link
Collaborator Author

/build

@holgerroth holgerroth enabled auto-merge (squash) May 21, 2024 19:18
@holgerroth
Copy link
Collaborator Author

/build

@holgerroth
Copy link
Collaborator Author

/build

@holgerroth holgerroth disabled auto-merge May 22, 2024 22:38
@YuanTingHsieh YuanTingHsieh mentioned this pull request May 22, 2024
Merged
6 tasks
@holgerroth
Copy link
Collaborator Author

/build

@holgerroth holgerroth enabled auto-merge (squash) May 22, 2024 23:58
@YuanTingHsieh
Copy link
Collaborator

/build

@holgerroth holgerroth merged commit 174cce9 into NVIDIA:main May 23, 2024
16 checks passed
@holgerroth holgerroth deleted the pythonic_getting_started branch May 23, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@yanchengnv yanchengnv Awaiting requested review from yanchengnv

@ZiyueXu77 ZiyueXu77 Awaiting requested review from ZiyueXu77

@SYangster SYangster Awaiting requested review from SYangster

@yhwen yhwen Awaiting requested review from yhwen

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@holgerroth @YuanTingHsieh @chesterxgchen @yhwen