cpp: add conditional range macros #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `NVTX3_FUNC_RANGE_IF` and `NVTX3_FUNC_RANGE_IN_IF` macros which are similar to the `NVTX3_FUNC_RANGE` and `NVTX3_FUNC_RANGE_IN` macros except that they only generate a range if the boolean expression passed as parameter evaluates to `true`. Closes NVIDIA#28
|
I tested by compiling a simple piece of code using |
jrhemstad
reviewed
Mar 27, 2021
jrhemstad
approved these changes
Mar 27, 2021
jrhemstad
reviewed
Mar 29, 2021
Add comment to clarify #endif Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
NVTX3_FUNC_RANGE_IFandNVTX3_FUNC_RANGE_IN_IFmacros whichare similar to the
NVTX3_FUNC_RANGEandNVTX3_FUNC_RANGE_INmacrosexcept that they only generate a range if the boolean expression
passed as parameter evaluates to
true.Closes #28