Tn tts e #3988
Merged
Tn tts e #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ekmb <ebakhturina@nvidia.com>
|
This pull request introduces 2 alerts when merging caa4fbd into 1a0575b - view on LGTM.com new alerts:
|
yzhang123
suggested changes
Apr 13, 2022
| #mytext#~hash mytext hash | ||
| test$~test dollar | ||
| covid-19~covid-nineteen | ||
| 55-millimeters long~fifty five-millimeters long |
There was a problem hiding this comment.
will #me2 or #me-too be normalized? not that it needs to be, just wondering what the extension of serial is
There was a problem hiding this comment.
yes, this is also supported
| # ) | ||
|
|
||
| keep_space = pynini.accep(" ") | ||
| # serial_graph = pynini.compose( |
fix lgtm? |
Signed-off-by: ekmb <ebakhturina@nvidia.com>
|
This pull request introduces 2 alerts when merging 8c09dfe into 9f7cb12 - view on LGTM.com new alerts:
|
Signed-off-by: ekmb <ebakhturina@nvidia.com>
yzhang123
approved these changes
Apr 14, 2022
|
This pull request introduces 2 alerts when merging 8545462 into d4408cc - view on LGTM.com new alerts:
|
yzhang123
previously approved these changes
Apr 14, 2022
Signed-off-by: ekmb <ebakhturina@nvidia.com>
Signed-off-by: ekmb <ebakhturina@nvidia.com>
Signed-off-by: ekmb <ebakhturina@nvidia.com>
yzhang123
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
On-going TN refactoring for TTS
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information