Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tokenization and Normalization pre-proecssing script for NMT #4557

Merged
merged 2 commits into from
Jul 16, 2022

Conversation

aklife97
Copy link
Collaborator

Signed-off-by: Abhinav Khattar aklife97@gmail.com

What does this PR do ?

Adds Tokenization and Normalization script

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
    python preprocess_tokenization_normalization.py --input-src train.en
    --input-tgt train.zh
    --output-src train.tok.norm.en
    --output-tgt train.tok.norm.zh
    --source-lang en
    --target-lang zh

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Abhinav Khattar <aklife97@gmail.com>
Signed-off-by: Abhinav Khattar <aklife97@gmail.com>
Copy link
Contributor

@MaximumEntropy MaximumEntropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MaximumEntropy MaximumEntropy merged commit fea3775 into main Jul 16, 2022
sarthmit pushed a commit to sarthmit/NeMo that referenced this pull request Jul 18, 2022
…DIA#4557)

* add script

Signed-off-by: Abhinav Khattar <aklife97@gmail.com>

* style fix

Signed-off-by: Abhinav Khattar <aklife97@gmail.com>
Signed-off-by: sarthmit <sarthmit@gmail.com>
sarthmit pushed a commit to sarthmit/NeMo that referenced this pull request Jul 18, 2022
…DIA#4557)

* add script

Signed-off-by: Abhinav Khattar <aklife97@gmail.com>

* style fix

Signed-off-by: Abhinav Khattar <aklife97@gmail.com>
Signed-off-by: sarthmit <sarthmit@gmail.com>
itzsimpl pushed a commit to itzsimpl/NeMo that referenced this pull request Jul 18, 2022
…DIA#4557)

* add script

Signed-off-by: Abhinav Khattar <aklife97@gmail.com>

* style fix

Signed-off-by: Abhinav Khattar <aklife97@gmail.com>
Signed-off-by: Iztok Lebar Bajec <ilb@fri.uni-lj.si>
@aklife97 aklife97 deleted the NMTpretoknorm branch July 19, 2022 23:45
arendu pushed a commit that referenced this pull request Jul 21, 2022
* add script

Signed-off-by: Abhinav Khattar <aklife97@gmail.com>

* style fix

Signed-off-by: Abhinav Khattar <aklife97@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Davood-M pushed a commit to Davood-M/NeMo that referenced this pull request Aug 9, 2022
…DIA#4557)

* add script

Signed-off-by: Abhinav Khattar <aklife97@gmail.com>

* style fix

Signed-off-by: Abhinav Khattar <aklife97@gmail.com>
Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
…DIA#4557)

* add script

Signed-off-by: Abhinav Khattar <aklife97@gmail.com>

* style fix

Signed-off-by: Abhinav Khattar <aklife97@gmail.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants