Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix megatron p tuning notebook #4741

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Fix megatron p tuning notebook #4741

merged 2 commits into from
Aug 15, 2022

Conversation

nithinraok
Copy link
Collaborator

@nithinraok nithinraok commented Aug 15, 2022 •
edited

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection:
NLP

Changelog

  • Fix issues with strategy and plugin mix (with PTL 1.7 upgrade)

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@nithinraok
move plugin to plugins arg
2d7dcb6 
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
@nithinraok
another instance
2de9e5a 
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
vadam5
vadam5 suggested changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@vadam5 vadam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix! Can you please merge it into r1.11.0 instead of main?

@nithinraok
Copy link
Collaborator Author

nithinraok commented Aug 15, 2022 •
edited

r1.11.0 doesn't need this fix since it runs on PTL 1.6.5.

@vadam5 vadam5 self-requested a review August 15, 2022 19:50
vadam5
vadam5 approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@vadam5 vadam5 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@nithinraok nithinraok merged commit 38cfcd9 into main Aug 15, 2022
@nithinraok nithinraok deleted the fix_megatron_p-tuning_notebook branch August 15, 2022 20:35
PeganovAnton pushed a commit that referenced this pull request Aug 24, 2022
@nithinraok @PeganovAnton
Fix megatron p tuning notebook (#4741)
d743d91 
* move plugin to plugins arg

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

* another instance

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
piraka9011 pushed a commit to piraka9011/NeMo that referenced this pull request Aug 25, 2022
@nithinraok @piraka9011
Fix megatron p tuning notebook (NVIDIA#4741)
e340420 
* move plugin to plugins arg

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

* another instance

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
@nithinraok
Fix megatron p tuning notebook (NVIDIA#4741)
bd0e36c 
* move plugin to plugins arg

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

* another instance

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadam5 vadam5 vadam5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nithinraok @vadam5