Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix megatron p tuning notebook #4741

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Fix megatron p tuning notebook #4741

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d7dcb6
move plugin to plugins arg
nithinraok Aug 15, 2022
2de9e5a
another instance
nithinraok Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions tutorials/nlp/Multitask_Prompt_and_PTuning.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,9 +837,6 @@
"# for PyTorch Native AMP set precision=16\n",
"config.trainer.precision = 16 if torch.cuda.is_available() else 32\n",
"\n",
"# remove distributed training flags\n",
"config.trainer.strategy = None\n",
"\n",
"# setup cluster environment parameters\"\n",
"# use torch elastic cluster environment so `create_process_externally` is True\n",
"# the launcher is set to None. It will not try to spawn new processes.\n",
Expand All @@ -848,8 +845,9 @@
"os.environ[\"RANK\"] = '0'\n",
"os.environ[\"WORLD_SIZE\"] = '1'\n",
"\n",
"strategy = NLPDDPStrategy(find_unused_parameters=False, no_ddp_communication_hook=True), TorchElasticEnvironment()\n",
"trainer = pl.Trainer(strategy=strategy, **config.trainer)\n",
"strategy = NLPDDPStrategy(find_unused_parameters=False,no_ddp_communication_hook=True)\n",
"plugins = [TorchElasticEnvironment()]\n",
"trainer = pl.Trainer(plugins= plugins, strategy=strategy, **config.trainer)\n",
"\n",
"print(\"Trainer config - \\n\")\n",
"print(OmegaConf.to_yaml(config.trainer))"
Expand Down Expand Up @@ -1136,8 +1134,9 @@
"config.model.optim.lr = 5e-4\n",
"\n",
"# Reset the trainer\n",
"strategy = NLPDDPStrategy(find_unused_parameters=False, no_ddp_communication_hook=True), TorchElasticEnvironment()\n",
"trainer = pl.Trainer(strategy=strategy, **config.trainer)\n",
"strategy = NLPDDPStrategy(find_unused_parameters=False, no_ddp_communication_hook=True)\n",
"plugins= [TorchElasticEnvironment()]\n",
"trainer = pl.Trainer(strategy=strategy, plugins=plugins, **config.trainer)\n",
"\n",
"print(\"Trainer config - \\n\")\n",
"print(OmegaConf.to_yaml(config.trainer))"
Expand Down Expand Up @@ -1282,7 +1281,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.8.13"
"version": "3.9.12"
}
},
"nbformat": 4,
Expand Down