Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chinese text normalization] speed up graph building #5128

Merged
merged 1 commit into from
Oct 14, 2022
Merged

[Chinese text normalization] speed up graph building #5128

merged 1 commit into from
Oct 14, 2022

Conversation

pengzhendong
Copy link
Contributor

Signed-off-by: 彭震东 275331498@qq.com

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@pengzhendong
Copy link
Contributor Author

pengzhendong commented Oct 9, 2022

@mzxcpp

wenet-e2e/WeTextProcessing#35
wenet-e2e/WeTextProcessing#36

@lgtm-com
Copy link

lgtm-com bot commented Oct 9, 2022

This pull request introduces 1 alert when merging 473d6a5 into 215e345 - view on LGTM.com

new alerts:

  • 1 for Unused import

Signed-off-by: 彭震东 <275331498@qq.com>
@lgtm-com
Copy link

lgtm-com bot commented Oct 13, 2022

This pull request introduces 1 alert when merging 83e0ac7 into 4463a9f - view on LGTM.com

new alerts:

  • 1 for Unused import

@ekmb ekmb merged commit a213f9e into NVIDIA:main Oct 14, 2022
@ekmb
Copy link
Collaborator

ekmb commented Oct 14, 2022

Thank you for the PR!

1-800-BAD-CODE pushed a commit to 1-800-BAD-CODE/NeMo that referenced this pull request Nov 13, 2022
Signed-off-by: 彭震东 <275331498@qq.com>

Signed-off-by: 彭震东 <275331498@qq.com>
Signed-off-by: 1-800-bad-code <shane.carroll@utsa.edu>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
Signed-off-by: 彭震东 <275331498@qq.com>

Signed-off-by: 彭震东 <275331498@qq.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
Signed-off-by: 彭震东 <275331498@qq.com>

Signed-off-by: 彭震东 <275331498@qq.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants