added python and c++ alignment code #5346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
|
This pull request introduces 2 alerts when merging b0adc4d into d37db88 - view on LGTM.com new alerts:
|
ekmb
requested changes
Nov 8, 2022
ekmb
reviewed
Nov 8, 2022
|
Assuming that the FST is deterministic and shortest path is considered, will there be multiple outgoing arcs? |
i don't think so |
Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
ekmb
approved these changes
Nov 15, 2022
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
* added python and c++ alignment code Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * moved files Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
* added python and c++ alignment code Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * moved files Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
JimmyZhang12
pushed a commit
to JimmyZhang12/NeMo
that referenced
this pull request
Dec 14, 2022
* added python and c++ alignment code Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * moved files Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
andrusenkoau
pushed a commit
to andrusenkoau/NeMo
that referenced
this pull request
Jan 5, 2023
* added python and c++ alignment code Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * moved files Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: andrusenkoau <andrusenkoau@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yang Zhang yangzhang@nvidia.com
What does this PR do ?
provides both python and c++ alignment
Collection: tools