Megatron Export Update #5423
Merged
Megatron Export Update #5423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* export update for Megatron + change ORT optimization Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated export_utils to use autocast instead of manually casting >:/ Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * removed dtype from LayerNorm Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * added comment Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * reverting changes on FloatCast Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * Cherry-picked changes from megatron-norm Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> * updated asr_model import to cast_utils Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * updated del onnx_model place Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * changed ort optimization to basic -> temp fix Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Boris Fomitchev <bfomitchev@nvidia.com>
|
This pull request introduces 1 alert when merging a16bdfa into 5665f14 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
|
This pull request introduces 1 alert when merging 03c8848 into 4f3e7b8 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
|
This pull request introduces 1 alert when merging 5a8704e into 1581327 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
borisfom
previously approved these changes
Nov 22, 2022
…ef10ff351eca6 Signed-off-by: Boris Fomitchev <borisfom@users.noreply.github.com>
borisfom
approved these changes
Nov 22, 2022
|
This pull request introduces 1 alert when merging 88b7573 into ed87156 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| exportable module | ||
| """ | ||
|
|
||
| mod = ExportableMatchedScaleMaskSoftmax(n.input_in_fp16, n.input_in_bf16, n.mask_func, n.softmax_in_fp32, n.scale) |
Check failure
Code scanning / CodeQL
Wrong number of arguments in a class instantiation
1-800-BAD-CODE
pushed a commit
to 1-800-BAD-CODE/NeMo
that referenced
this pull request
Nov 26, 2022
* export update for Megatron + change ORT optimization Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated export_utils to use autocast instead of manually casting >:/ Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * removed dtype from LayerNorm Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * added comment Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * reverting changes on FloatCast Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * Cherry-picked changes from megatron-norm Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> * updated asr_model import to cast_utils Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * updated del onnx_model place Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * changed ort optimization to basic -> temp fix Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Boris Fomitchev <borisfom@users.noreply.github.com> Co-authored-by: David <amosalla@asu.edu> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Boris Fomitchev <bfomitchev@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com> Signed-off-by: shane carroll <shane.carroll@utsa.edu>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
* export update for Megatron + change ORT optimization Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated export_utils to use autocast instead of manually casting >:/ Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * removed dtype from LayerNorm Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * added comment Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * reverting changes on FloatCast Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * Cherry-picked changes from megatron-norm Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> * updated asr_model import to cast_utils Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * updated del onnx_model place Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * changed ort optimization to basic -> temp fix Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Boris Fomitchev <borisfom@users.noreply.github.com> Co-authored-by: David <amosalla@asu.edu> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Boris Fomitchev <bfomitchev@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
* export update for Megatron + change ORT optimization Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated export_utils to use autocast instead of manually casting >:/ Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * removed dtype from LayerNorm Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * added comment Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * reverting changes on FloatCast Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * Cherry-picked changes from megatron-norm Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> * updated asr_model import to cast_utils Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * updated del onnx_model place Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * changed ort optimization to basic -> temp fix Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Boris Fomitchev <borisfom@users.noreply.github.com> Co-authored-by: David <amosalla@asu.edu> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Boris Fomitchev <bfomitchev@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Dec 5, 2022
* export update for Megatron + change ORT optimization Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated export_utils to use autocast instead of manually casting >:/ Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * removed dtype from LayerNorm Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * added comment Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * reverting changes on FloatCast Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * Cherry-picked changes from megatron-norm Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> * updated asr_model import to cast_utils Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * updated del onnx_model place Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * changed ort optimization to basic -> temp fix Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Boris Fomitchev <borisfom@users.noreply.github.com> Co-authored-by: David <amosalla@asu.edu> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Boris Fomitchev <bfomitchev@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
andrusenkoau
pushed a commit
to andrusenkoau/NeMo
that referenced
this pull request
Jan 5, 2023
* export update for Megatron + change ORT optimization Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated export_utils to use autocast instead of manually casting >:/ Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * removed dtype from LayerNorm Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * added comment Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * reverting changes on FloatCast Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * Cherry-picked changes from megatron-norm Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> * updated asr_model import to cast_utils Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * updated del onnx_model place Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * changed ort optimization to basic -> temp fix Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Boris Fomitchev <borisfom@users.noreply.github.com> Co-authored-by: David <amosalla@asu.edu> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Boris Fomitchev <bfomitchev@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com> Signed-off-by: andrusenkoau <andrusenkoau@gmail.com>
XuesongYang
deleted the
cherry-pick-main-68cd1a75a04cd34fdbb89b1c663ef10ff351eca6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Mosallanezhad dmosallanezh@nvidia.com
What does this PR do ?
Updates export process for Megatron-based models
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information