Radtts 1.13 plus #5471
Merged
Radtts 1.13 plus #5471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* [TTS] Fixing RADTTS training - removing view buffer and fixing accuracy issue (#5358) * Fixing RADTTS training - removing view buffer and fixing accuracy issue * Fixes for Torchscript/Triton * Added autocast to radtts UT * using cuda() for training example Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com>
|
This pull request fixes 1 alert when merging b2a9e9b into 96e8ae7 - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog. |
borisfom
approved these changes
Nov 21, 2022
XuesongYang
deleted the
cherry-pick-main-4b48ea89042778fd29f084c1ef243378f1a5abb3
branch
1-800-BAD-CODE
pushed a commit
to 1-800-BAD-CODE/NeMo
that referenced
this pull request
Nov 26, 2022
* [TTS] Fixing RADTTS training - removing view buffer and fixing accuracy issue (NVIDIA#5358) * Fixing RADTTS training - removing view buffer and fixing accuracy issue * Fixes for Torchscript/Triton * Added autocast to radtts UT * using cuda() for training example Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Signed-off-by: shane carroll <shane.carroll@utsa.edu>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
* [TTS] Fixing RADTTS training - removing view buffer and fixing accuracy issue (NVIDIA#5358) * Fixing RADTTS training - removing view buffer and fixing accuracy issue * Fixes for Torchscript/Triton * Added autocast to radtts UT * using cuda() for training example Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
* [TTS] Fixing RADTTS training - removing view buffer and fixing accuracy issue (NVIDIA#5358) * Fixing RADTTS training - removing view buffer and fixing accuracy issue * Fixes for Torchscript/Triton * Added autocast to radtts UT * using cuda() for training example Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
andrusenkoau
pushed a commit
to andrusenkoau/NeMo
that referenced
this pull request
Jan 5, 2023
* [TTS] Fixing RADTTS training - removing view buffer and fixing accuracy issue (NVIDIA#5358) * Fixing RADTTS training - removing view buffer and fixing accuracy issue * Fixes for Torchscript/Triton * Added autocast to radtts UT * using cuda() for training example Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Signed-off-by: andrusenkoau <andrusenkoau@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
I finally managed to properly script only necessary part, and added a guard that works around the issue with auto-casted TorchScript not workin in non-Python environment (Triton)
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information