added set_start_method + function param bugfix #5545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* added set_start_method + function param bugfix Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * upper bound torchmetrics Signed-off-by: ericharper <complex451@gmail.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ericharper <complex451@gmail.com>
ericharper
requested changes
Dec 5, 2022
for more information, see https://pre-commit.ci
|
This pull request fixes 2 alerts when merging 7123957 into fa46393 - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog. |
Signed-off-by: ericharper <complex451@gmail.com>
…81' of github.com:NVIDIA/NeMo into cherry-pick-main-53dae726c3fea248e798f0ad27301259b9593881
|
This pull request fixes 2 alerts when merging db9c7ac into 1f5b8ca - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog. |
ericharper
deleted the
cherry-pick-main-53dae726c3fea248e798f0ad27301259b9593881
branch
andrusenkoau
pushed a commit
to andrusenkoau/NeMo
that referenced
this pull request
Jan 5, 2023
* added set_start_method + function param bugfix (NVIDIA#5539) * added set_start_method + function param bugfix Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * upper bound torchmetrics Signed-off-by: ericharper <complex451@gmail.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ericharper <complex451@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * revert requirements Signed-off-by: ericharper <complex451@gmail.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: David <amosalla@asu.edu> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ericharper <complex451@gmail.com> Signed-off-by: andrusenkoau <andrusenkoau@gmail.com>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
* added set_start_method + function param bugfix (NVIDIA#5539) * added set_start_method + function param bugfix Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * upper bound torchmetrics Signed-off-by: ericharper <complex451@gmail.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ericharper <complex451@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * revert requirements Signed-off-by: ericharper <complex451@gmail.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: David <amosalla@asu.edu> Co-authored-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ericharper <complex451@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Mosallanezhad dmosallanezh@nvidia.com
What does this PR do ?
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information