Add support for Time Stamp calculation using transcribe_speech.py #5568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VahidooX
approved these changes
Dec 7, 2022
| compute_langs: Bool to request language ID information (if the model supports it) | ||
|
|
||
| (Optionally: You can limit the type of timestamp computations using below overrides) | ||
| ctc_decoding.ctc_timestamp_type="all" # (default all, can be [all, char, word]) |
There was a problem hiding this comment.
It may not related to this PR, but can we make the name of the param for both ctc and rnnt the same, something like timestamp_type?
There was a problem hiding this comment.
Possible. I wanted it to be explicit cause technically hybrid models might overwrite each other value but it turns out it's not the case
| if compute_timestamps: | ||
| timestamps = transcriptions[idx].timestep | ||
| if timestamps is not None and isinstance(timestamps, dict): | ||
| timestamps.pop( |
There was a problem hiding this comment.
Is poping done to save cpu or gpu memory?
There was a problem hiding this comment.
The item there is a torch tensor with just integer IDs corresponding to location in audio stream where some text token was emitted. Very low utilities and is just a building block for the char and word based dicts
andrusenkoau
pushed a commit
to andrusenkoau/NeMo
that referenced
this pull request
Jan 5, 2023
Signed-off-by: smajumdar <titu1994@gmail.com> Signed-off-by: smajumdar <titu1994@gmail.com> Co-authored-by: Vahid Noroozi <VahidooX@users.noreply.github.com> Signed-off-by: andrusenkoau <andrusenkoau@gmail.com>
titu1994
added a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
Signed-off-by: smajumdar <titu1994@gmail.com> Signed-off-by: smajumdar <titu1994@gmail.com> Co-authored-by: Vahid Noroozi <VahidooX@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: smajumdar titu1994@gmail.com
What does this PR do ?
Adds flag to compute word and char level timestamp using the transcribe speech script.
Collection: [ASR]
Changelog
Usage
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?