Skip top_p computations when set to 1.0 #8905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Delalleau <507137+odelalleau@users.noreply.github.com>
|
jenkins |
odelalleau
added a commit
to NVIDIA/NeMo-Aligner
that referenced
this pull request
Apr 12, 2024
This is because we otherwise do useless computations, at least until
NVIDIA/NeMo#8905
is merged
odelalleau
added a commit
to NVIDIA/NeMo-Aligner
that referenced
this pull request
Apr 12, 2024
This is because we otherwise do useless computations, at least until
NVIDIA/NeMo#8905
is merged
Signed-off-by: Olivier Delalleau <507137+odelalleau@users.noreply.github.com>
|
jenkins |
|
jenkins |
xingyaoww
pushed a commit
to xingyaoww/NeMo
that referenced
this pull request
Apr 23, 2024
Signed-off-by: Olivier Delalleau <507137+odelalleau@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
alxzhang-amazon
pushed a commit
to alxzhang-amazon/NeMo
that referenced
this pull request
Apr 26, 2024
Signed-off-by: Olivier Delalleau <507137+odelalleau@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
galv
pushed a commit
to galv/NeMo
that referenced
this pull request
Apr 29, 2024
Signed-off-by: Olivier Delalleau <507137+odelalleau@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
suiyoubi
pushed a commit
that referenced
this pull request
May 2, 2024
Signed-off-by: Olivier Delalleau <507137+odelalleau@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com> Signed-off-by: Ao Tang <aot@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This avoid doing useless computations (that may even filter out some tokens due to numerical approximation) when
top_p=1.0(which is not supposed to have any effect).Collection: nlp
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type:
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.