Improved shard_id parsing in LazyNemoTarredIterator, enables AIS dataloading
#9077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
| m = pattern.match(p) | ||
| assert m is not None, f"Cannot determine shard_id from manifest path: {p}" | ||
| m = json_pattern.search(p) | ||
| assert m is not None, f"Cannot determine shard_id from manifest input specified: {p}" |
There was a problem hiding this comment.
can we be little more verbose in error msg? i.e. tell why it failed.. ? (for example: input_0.json).
same for tar files below.
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
krishnacpuvvada
approved these changes
May 2, 2024
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
…dataloading (NVIDIA#9077) * More permissive shard_id parsing, enables AIS dataloading Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix to shard id discovery Signed-off-by: Piotr Żelasko <petezor@gmail.com> * More informative assertion errors Signed-off-by: Piotr Żelasko <petezor@gmail.com> --------- Signed-off-by: Piotr Żelasko <petezor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Improves the path-based
shard_idparsing inLazyNemoTarredIterator; removes the assumption of a rigid path structure and instead searches the string with regex pattern that must containmanifest/audio,_(shard_id), andjson/tarwith no slashes in between. It allows loading data directly from AIStore (pipe:ais get ais://bucket/audio_{0..N}.tar -) and other cloud storage CLIs; it also allows more path patterns such asmanifest_0_punctuation.json(CC @krishnacpuvvada).For example, it's possible to train a NeMo model from AIStore data just by passing the following config options (assuming
aisbinary is available):Finally it improves the assertion messages about mismatches in paths/shard_ids/items between JSON and tar inputs to provide more details for debugging multi-dataset setups with wrong input specification.
Collection: ASR, multimodal
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
There's no need to comment
jenkinson the PR to trigger Jenkins CI.The GitHub Actions CI will run automatically when the PR is opened.
To run CI on an untrusted fork, a NeMo user with write access must click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information