Add option to merge distributed optimizer buckets #9414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: timmoon10 <timmoon10@users.noreply.github.com>
|
@ericharper |
galv
pushed a commit
to galv/NeMo
that referenced
this pull request
Jun 13, 2024
* Add option to merge distopt buckets in GPT Signed-off-by: Tim Moon <tmoon@nvidia.com> * Move distopt bucket merge logic to base LLM class Signed-off-by: Tim Moon <tmoon@nvidia.com> * Apply isort and black reformatting Signed-off-by: timmoon10 <timmoon10@users.noreply.github.com> --------- Signed-off-by: Tim Moon <tmoon@nvidia.com> Signed-off-by: timmoon10 <timmoon10@users.noreply.github.com> Co-authored-by: timmoon10 <timmoon10@users.noreply.github.com> Co-authored-by: Sangkug Lym <slym@nvidia.com>
JesusPaz
pushed a commit
to JesusPaz/NeMo
that referenced
this pull request
Jun 18, 2024
* Add option to merge distopt buckets in GPT Signed-off-by: Tim Moon <tmoon@nvidia.com> * Move distopt bucket merge logic to base LLM class Signed-off-by: Tim Moon <tmoon@nvidia.com> * Apply isort and black reformatting Signed-off-by: timmoon10 <timmoon10@users.noreply.github.com> --------- Signed-off-by: Tim Moon <tmoon@nvidia.com> Signed-off-by: timmoon10 <timmoon10@users.noreply.github.com> Co-authored-by: timmoon10 <timmoon10@users.noreply.github.com> Co-authored-by: Sangkug Lym <slym@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* Add option to merge distopt buckets in GPT Signed-off-by: Tim Moon <tmoon@nvidia.com> * Move distopt bucket merge logic to base LLM class Signed-off-by: Tim Moon <tmoon@nvidia.com> * Apply isort and black reformatting Signed-off-by: timmoon10 <timmoon10@users.noreply.github.com> --------- Signed-off-by: Tim Moon <tmoon@nvidia.com> Signed-off-by: timmoon10 <timmoon10@users.noreply.github.com> Co-authored-by: timmoon10 <timmoon10@users.noreply.github.com> Co-authored-by: Sangkug Lym <slym@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds an option to merge distributed optimizer buckets with GPT. By default each bucket corresponds to a Transformer layer (without interleaved pipeline parallelism) or to virtual pipeline parallel stage (with interleaved pipeline parallelism)
Collection: NLP
Changelog
Usage
Run GPT, e.g. with the config at https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/language_modeling/conf/megatron_gpt_config.yaml.
Enable the distributed optimizer with
model.optim.name=distributed_fused_adamand merge buckets withmodel.distributed_adam_bucket_merge_size=<N>.For example, if training GPT without pipeline parallelism,
model.distributed_adam_bucket_merge_size=2will cause each distopt bucket to contain the weights of two Transformer layers.GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Pinging @erhoo82.
Additional Information